Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playvideos: improves Content-Security-Policy (CSP) compliance #2110

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

thican
Copy link

@thican thican commented Nov 16, 2024

Improves situation for #1513.

I hope it can integrate milestone 0.14.0 (#2105).

@nodiscc nodiscc added this to the 0.14.0 milestone Nov 17, 2024
@nodiscc nodiscc self-requested a review November 17, 2024 11:11
Copy link
Member

@nodiscc nodiscc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're at it, couldn't we automate the download of https://code.jquery.com/jquery-3.7.1.min.js during frontend builds? Instead of vendoring a massive minified js file

@thican
Copy link
Author

thican commented Nov 17, 2024

While we're at it, couldn't we automate the download of https://code.jquery.com/jquery-3.7.1.min.js during frontend builds? Instead of vendoring a massive minified js file

Good idea, just I am not aware on how to make it work (yet?) but I approve this.

@thican
Copy link
Author

thican commented Nov 17, 2024

I guess the plugin could be rewritten to discard usage of jquery, nowadays, no? I am not a Web dev so I might be wrong ;-)
As far as I understand the code of this plugin (why is it so much obfuscated!?), it simplifies the creation of tag such as div and a with CSS content to only create the play box which hold the frame for the video host. I guess jQuery is not really required with modern browsers for just those capabilities, no?

However I am a bit lost with the frontend build usage, I managed to integrate jquery with the correct version and verified its fingerprints, but is it okay then I load the JS script from its path node_modules/jquery/dist/jquery.min.js?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants