Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

making rfta test run faster and fixing bug in rfta #124

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Conversation

odedstein
Copy link
Collaborator

This PR makes the RFTA tests significantly faster, and it also fixes a subtle bug in the RFTA function. It also changes an RFTA default argument. There is also now an option in the RFTA function to force CPU rasterization.

@sgsellan
Copy link
Owner

sgsellan commented Jun 4, 2024

From the action:

======================================================================
FAIL: test_noop (test.test_reach_for_the_arcs.TestReachForTheArcs)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/runner/work/gpytoolbox/gpytoolbox/test/test_reach_for_the_arcs.py", line 68, in test_noop
    self.assertTrue(h < 0.1)
AssertionError: False is not true

----------------------------------------------------------------------

@sgsellan sgsellan added the ready to merge This PR is finished and will be merged for the next release label Jun 4, 2024
@odedstein odedstein merged commit 42b666c into main Jun 5, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge This PR is finished and will be merged for the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants