Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address numpy deprecation warning #122

Merged
merged 1 commit into from
Jun 2, 2024
Merged

Address numpy deprecation warning #122

merged 1 commit into from
Jun 2, 2024

Conversation

odedstein
Copy link
Collaborator

This PR is meant to address a variety of numpy deprecation warnings that we are getting on newer numpy versions:

DeprecationWarning: Conversion of an array with ndim > 0 to a scalar
is deprecated, and will error in future. Ensure you extract a single
element from your array before performing this operation. (Deprecated
NumPy 1.25.)

It seems like it can be easily fixed by just using np.squeeze... right?

@odedstein odedstein requested a review from sgsellan June 1, 2024 22:25
sgsellan
sgsellan approved these changes Jun 2, 2024
View reviewed changes
Copy link
Owner

@sgsellan sgsellan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@sgsellan sgsellan added the ready to merge This PR is finished and will be merged for the next release label Jun 2, 2024
@odedstein odedstein merged commit 3235115 into main Jun 2, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgsellan sgsellan sgsellan approved these changes

Assignees

@sgsellan sgsellan

Labels
ready to merge This PR is finished and will be merged for the next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@odedstein @sgsellan