Reach for the arcs #121
Merged
Reach for the arcs #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The built currently fails on Windows. |
|
The previous tests seemed to be timing out in an install, so I am trying out removing it... |
|
The Linux wheels seem to build correctly now after the latest change. |
odedstein
added
the
ready to merge
|
If the merge commit clears all tests, this can be merged. |
odedstein
removed
the
ready to merge
|
Added an extra check to the RFTS singularity catching, now that we don't consistently get NaNs in the vertex values (because of our fix of #119 ). A liiiitle uneasy that the tests only failed in some OS, but it should be fixed now. I am happy to merge if this looks reasonable to you and checks pass |
sgsellan
approved these changes
Jun 2, 2024
sgsellan
added
merge after checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the code to perform reach_for_the_arcs to Gpytoolbox.
@sgsellan please check whether this is ok, and whether we should tweak any RFTA default parameters.
Also please take a look at whether you like the unit tests.
This pull request depends on #117 , and should only be merged after that one has been merged.