adding DEC operators #116
Merged
adding DEC operators #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgsellan
reviewed
Apr 26, 2024
|
I don't care whether we have separate files for this or not, I have no strong feelings. |
sgsellan
reviewed
May 5, 2024
src/gpytoolbox/dec_h1.py
Outdated
| """ | ||
|
|
||
| l_sq = halfedge_lengths_squared(V,F) | ||
| return dec_h1_intrinsic(l_sq,F,E_to_he=E_to_he) |
There was a problem hiding this comment.
Aha! Shouldn't this be dec_h1inv_intrinsic?
|
See typo above. We did not catch that typo due to a bigger problem: unless I am missing something, currently, the |
|
Good point. Will fix this and add unit tests. |
|
This looks good to me now! Happy to merge |
sgsellan
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds DEC operators in the style of https://www.cs.cmu.edu/~kmcrane/Projects/DDG/
@sgsellan I'd be glad if you could double check to make sure I did these correctly :)