-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduced memory requirement for filterPeaks; closes #71 #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #72 +/- ##
==========================================
+ Coverage 88.44% 88.46% +0.01%
==========================================
Files 81 82 +1
Lines 1411 1413 +2
==========================================
+ Hits 1248 1250 +2
Misses 163 163
Continue to review full report at Codecov.
|
Dear Sebastian, That sounds great! BW, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear @paoloinglese,
thanks again for your great contribution in PR #71.
Unfortunately I can't modify your PR. That's why I closed #71 it and add this new one.
I did just a few minor changes (e.g. replacing the
lapply(l, above.min)
withtabulate
).If you are happy with this changes I will merge it into the main branch.
Best wishes,
Sebastian
BTW: will this make #70 obsolete for you?