CI: add Ubuntu 24.04 #72
Conversation
sgallagher
commented
Dec 11, 2024
sgallagher
commented
- Add build-essential dep for Ubuntu CI
|
@martinpitt This is failing to build the Debian package in CI for Ubuntu 24.04 and I can't figure out why. It works fine when I run the steps manually in an |
packaging/debian/control
Outdated
| @@ -9,6 +9,7 @@ Build-Depends: debhelper-compat (= 12), | |||
| libssl-dev, | |||
| libtalloc-dev, | |||
| pkgconf, | |||
| build-essential, | |||
There was a problem hiding this comment.
Please don't do that. build-essential is implicitly present in all official Debian build environments, it shouldn't go into debian/control. You also don't have anything in your ci.yml workflow which would actually look at the declared build-deps here. Instead, add build-essential to the sudo apt install list in the workflow.
|
I.e. notice how the install step does not actually install |
* Add build-essential dep for Ubuntu CI Signed-off-by: Stephen Gallagher <[email protected]>
|
@sgallagher nice! The get_current_version source build failure is almost surely something else? |
|
Yeah, I need to look into that next, I suppose. I haven't updated my Packit config for this project in years, so I'm not surprised something might have broken... |
