Add a requirement to discard invalid ciphertexts #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bren2010
reviewed
Dec 4, 2023
Co-authored-by: Brendan McMillion <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds text requiring ciphertexts that do not decrypt to be discarded. It also adds some discussion of the impact of this requirement on the safety of short tags. (Thanks to @Bren2010 for helping refine this analysis.)
@chris-wood - in #154 you mention addressing AEAD limits. Could you suggest some text for that? I was not able to interpret the CFRG draft. Also, it seems like we would need some analogous analysis for the AES-CTR-based AEAD modes described here. Do you have thoughts on that?