-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify documentation of update remove_empties.R #569
Conversation
Fixes sfirke#568 Feel free to edit or change, it is a bit difficult to write a clear description. Added a clarification for lower and higher values.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #569 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 27 27
Lines 1274 1274
=========================================
Hits 1274 1274
|
The update looks good. Can you please update the full documentation ( |
Hi, |
This looks good to me! |
This is a tricky one to describe in a brief and clear way 😅 @matanhakim and @billdenney what do you think of my attempt that built on Matan's - anything still to improve? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me with the current edits.
This looks great to me. Indeed a tricky explanation! |
Fixes #568
Feel free to edit or change, it is a bit difficult to write a clear description.
Added a clarification for lower and higher values.