Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify documentation of update remove_empties.R #569

Merged
merged 6 commits into from
Nov 25, 2024

Conversation

matanhakim
Copy link
Contributor

Fixes #568

Feel free to edit or change, it is a bit difficult to write a clear description.
Added a clarification for lower and higher values.

Fixes sfirke#568 

Feel free to edit or change, it is a bit difficult to write a clear description.
Added a clarification for lower and higher values.
Copy link

codecov bot commented Mar 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3769ab0) to head (f89767b).

Current head f89767b differs from pull request most recent head be57f3b

Please upload reports for the commit be57f3b to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #569   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           27        27           
  Lines         1274      1274           
=========================================
  Hits          1274      1274           
Files Coverage Δ
R/remove_empties.R 100.00% <ø> (ø)

@billdenney
Copy link
Collaborator

The update looks good. Can you please update the full documentation (devtools::document()) so that everything is consistent and push that update?

@matanhakim
Copy link
Contributor Author

Hi,
I added the documentation.
You're welcome to have a look and provide feedback as necessary.
Thanks!

@billdenney
Copy link
Collaborator

This looks good to me!

R/remove_empties.R Outdated Show resolved Hide resolved
R/remove_empties.R Outdated Show resolved Hide resolved
R/remove_empties.R Outdated Show resolved Hide resolved
R/remove_empties.R Outdated Show resolved Hide resolved
@sfirke
Copy link
Owner

sfirke commented Nov 25, 2024

This is a tricky one to describe in a brief and clear way 😅 @matanhakim and @billdenney what do you think of my attempt that built on Matan's - anything still to improve?

@sfirke sfirke requested review from sfirke and billdenney and removed request for sfirke November 25, 2024 15:58
@sfirke sfirke added this to the v2.3 milestone Nov 25, 2024
Copy link
Collaborator

@billdenney billdenney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me with the current edits.

@sfirke sfirke changed the title Update remove_empties.R Clarify documentation of update remove_empties.R Nov 25, 2024
@sfirke sfirke merged commit ef4ac5f into sfirke:main Nov 25, 2024
7 checks passed
@matanhakim
Copy link
Contributor Author

This looks great to me. Indeed a tricky explanation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cutoff argument in remove_empty() is being implemented confusingly
3 participants