A "idiomatic" implementation variant of Findminmax #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julia 1.0 dropped this deprecation
jd-foster
changed the title
|
Not sure if you have any thoughts on this; strengths or weaknesses? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Seth, Based on your suggestion, here is a PR identical to JuliaMath#62. It should help to view the diff against your PR branch. There are hopefully some features here that could be merged. I was impressed by your approach that mirrors Julia Base code style, but the reason I put this together was that I couldn't understand how to debug the CI error, and it might be helpful for others in the future to read a more "elementary" code style.
The approach taken in this PR is to adhere more closely to how NaNMath already does things, namely only support
AbstractFloatiterables, including nomissingsupport. The extension toAbstractDictandNamedTupleis somewhat of a (worthwhile) departure already from the existing functions of NaNMath, so we're careful about being explicit about what can be accepted.