Fix mozjs-sys always being out of date #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great investigation work. I'm really looking forward to this change. |
jschwe
changed the title
- `src/rustfmt.toml` does not exist, so always out of date - the configure script is touched by the makefile, so the second build will always be out of date, even without changes. - bindgen::CargoCallbacks will by default tell Cargo to rerun the build-script if any of the included files change. In our case some of the included files are generated by the build-script, so their mtime will always be newer than when the build-script last ran causing cargo to needlessly rerun the build-script. Writing a customized Callback that ignores generated include files avoids this problem Signed-off-by: Jonathan Schwender <[email protected]>
Signed-off-by: Jonathan Schwender <[email protected]>
jschwe
changed the title
jschwe
added a commit
to jschwe/servo
that referenced
this pull request
Nov 22, 2024
Companion PR to servo/mozjs#524 This should reduce rebuilds when not using the prebuilt artifact (e.g. when `debug-mozjs` is true) Signed-off-by: Jonathan Schwender <[email protected]>
3 tasks
github-merge-queue bot
pushed a commit
to servo/servo
that referenced
this pull request
Nov 22, 2024
Companion PR to servo/mozjs#524 This should reduce rebuilds when not using the prebuilt artifact (e.g. when `debug-mozjs` is true) Signed-off-by: Jonathan Schwender <[email protected]>
github-merge-queue bot
pushed a commit
to servo/servo
that referenced
this pull request
Nov 22, 2024
Companion PR to servo/mozjs#524 This should reduce rebuilds when not using the prebuilt artifact (e.g. when `debug-mozjs` is true) Signed-off-by: Jonathan Schwender <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src/rustfmt.tomldoes not exist, so always out of dateIn our case some of the included files are generated by the build-script, so their mtime will always be newer than
when the build-script last ran causing cargo to needlessly rerun the build-script. Writing a customized Callback that ignores generated include files avoids this problem