Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normal formatting & fixes generate_wrappers.sh #379

Merged
merged 6 commits into from
Sep 4, 2023
Merged

Normal formatting & fixes generate_wrappers.sh #379

merged 6 commits into from
Sep 4, 2023

Conversation

sagudev
Copy link
Member

@sagudev sagudev commented Sep 1, 2023 •
edited
Loading

Fixes #378

  • normal fmt everywhere (gen_wrapper does own formatting on cloned files)
  • gen_wrapper script repaired and now works with both gsed and sed
  • wrapper files regenerated

sagudev
sagudev commented Sep 1, 2023
View reviewed changes
rust-mozjs/src/rust.rs Outdated Show resolved Hide resolved
@mukilan
Copy link
Member

mukilan commented Sep 4, 2023

Thank you for this fix! Overall it looks good, but I've left a comment about the change in formatting of glue.rs. Also, I'm looking into the windows build failure (I'm trying to switch to windows-2019 for now).

@sagudev
Copy link
Member Author

sagudev commented Sep 4, 2023

Also, I'm looking into the windows build failure (I'm trying to switch to windows-2019 for now).

Actually as noted in #368 the problem is actions/runner-images#8125 so manually installing llvm 16 should solve the problem. But I would just wait for the fix to be deployed it should be pretty soon as there was no deployment on windows for nearly two weeks.

@sagudev sagudev requested a review from mukilan September 4, 2023 12:19
@sagudev sagudev requested a review from mukilan September 4, 2023 15:16
@sagudev sagudev changed the title Special fmt for glue.rs & fixes generate_wrappers.sh Normal formatting & fixes generate_wrappers.sh Sep 4, 2023
mukilan
mukilan approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@mukilan mukilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mukilan mukilan added this pull request to the merge queue Sep 4, 2023
Merged via the queue into servo:master with commit 21dad0b Sep 4, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mukilan mukilan mukilan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix generate_wrappers script
2 participants
@sagudev @mukilan