Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the integrity check on CI #371

Merged
merged 1 commit into from
Aug 17, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 23 additions & 19 deletions .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -102,25 +102,29 @@ jobs:
shell: cmd
run: |
cargo test --verbose ${{ matrix.features }}
Integrity:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Get mozjs
run: |
bash ./mozjs/etc/get_mozjs.sh
- name: Apply patch
run: |
python3 ./mozjs/etc/update.py --no-commit mozjs.tar.xz
# Run `git add` here to force CRLF converted into LF
# so that we can check diff properly in next run
git add --all mozjs
- name: Check patch integrity
working-directory: ./mozjs
# Because we've added files in previous run, we need to
# check diff with `--staged`.
run: |
git diff --staged --no-ext-diff --quiet --exit-code

# The integrity check is currently broken. See issue #345.
#
# Integrity:
# runs-on: ubuntu-latest
# steps:
# - uses: actions/checkout@v3
# - name: Get mozjs
# run: |
# bash ./mozjs/etc/get_mozjs.sh
# - name: Apply patch
# run: |
# python3 ./mozjs/etc/update.py --no-commit mozjs.tar.xz
# # Run `git add` here to force CRLF converted into LF
# # so that we can check diff properly in next run
# git add --all mozjs
# - name: Check patch integrity
# working-directory: ./mozjs
# # Because we've added files in previous run, we need to
# # check diff with `--staged`.
# run: |
# git diff --staged --no-ext-diff --quiet --exit-code

build_result:
name: Result
runs-on: ubuntu-latest
Expand Down