Add support for Android NDK r21 #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrobinson
force-pushed
the
android-build
branch
6 times, most recently
from
15a22fb
to
46d67eb
Compare
This is the essentially the NDK that the version of SpiderMonkey supports. This makes a few changes to the SpiderMonkey source as well: 1. Pulls in a change from a more recent version so that the correct version of the clock functions are used. 2. Disables all attempts by SpiderMonkey to set the sysroot, Android platform includes, and the STL. Modern NDKs don't require these flags, they often just break mysteriously if not used perfectly. SpiderMonkey upstream is starting to use them less, but is still pretty far in the past. This makes everything about the Android build simpler. In addition, some compilation errors for 32-bit machines are fixed.
mrobinson
force-pushed
the
android-build
branch
from
46d67eb
to
9617753
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the essentially the NDK that the version of SpiderMonkey
supports. This makes a few changes to the SpiderMonkey source as well:
version of the clock functions are used.
platform includes, and the STL. Modern NDKs don't require these
flags and they often just break mysteriously if not used perfectly.
SpiderMonkey upstream is starting to use them less, but is still
pretty far in the past. This makes everything about the Android build
simpler.
In addition, some compilation errors for 32-bit machines are fixed.