Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 8.4 support #497

Merged
merged 4 commits into from
Nov 22, 2024
Merged

Add PHP 8.4 support #497

merged 4 commits into from
Nov 22, 2024

Conversation

tomschlick
Copy link
Contributor

@tomschlick tomschlick commented Nov 21, 2024

Attempted to do the initial setup for PHP 8.4 support here.

The official images at docker.io/library/php haven't been built yet so we will have to wait for those to fully test and merge. Keeping this as draft until then.

@tomschlick
Copy link
Contributor Author

tomschlick commented Nov 21, 2024

Official Base Image PR for tracking:

@jaydrogers
Copy link
Member

Sweet, thanks Tom!!

I will keep an eye on this and will merge as soon as the official images are available 👍

@jaydrogers jaydrogers changed the title add configuration for php 8.4 support Add PHP 8.4 support Nov 21, 2024
@jaydrogers
Copy link
Member

It's been merged, now we just have to keep an eye on this https://doi-janky.infosiftr.net/job/multiarch/job/amd64/job/php/

@tomschlick
Copy link
Contributor Author

Tags are now on dockerhub! https://hub.docker.com/_/php/tags?name=8.4.1

@jaydrogers jaydrogers marked this pull request as ready for review November 21, 2024 18:44
@jaydrogers
Copy link
Member

We still have to wait 😃

The images are published, but they don't have any actual images pushed.

8.4 images without architectures

image

Older 8.3 images with different architectures

image

@tomschlick
Copy link
Contributor Author

Yeah just noticed all the failures. Looks like that Jenkins project is marked as disabled. Not sure if they are still using that or moved to something else.

@jaydrogers
Copy link
Member

I wonder if they have it manually disabled until they are ready to run?

Usually that's what they've used in the past. It's still linked from their README, so I will just kind of keep an eye on it.

In my experience, it takes quite some time for the images to build. Keep me posted if you see anything else in the meantime.

Thanks for all your help!

@tomschlick
Copy link
Contributor Author

Yeah it looks like from the build history that its rebuilding every PHP version starting with 8.1 so it will probably take a while: https://doi-janky.infosiftr.net/job/meta/view/builds/builds -- Only still not seeing any amd64 in that list though.

@jaydrogers
Copy link
Member

8.1.31 (a new patch version for 8.1) is killing the process 🙃

I think we're gonna just have to try again tomorrow. The AMD64 architecture is appearing for some, but they are missing the ARM64 architecture.

image

@tomschlick
Copy link
Contributor Author

Sooo close, yet so far away 😢

@tomschlick
Copy link
Contributor Author

@jaydrogers jaydrogers merged commit 900736a into serversideup:main Nov 22, 2024
49 checks passed
@jaydrogers
Copy link
Member

Woohoo!

CI passed, so I merged it and I am running a beta release now 😅🤞

https://github.com/serversideup/docker-php/actions/runs/11966269031

If that passes, I will push these to stable tomorrow 👍

@jaydrogers
Copy link
Member

It's all published! 🥳

https://github.com/serversideup/docker-php/releases/tag/v3.5.0

Thanks for your help @tomschlick!

@tomschlick tomschlick deleted the patch-1 branch November 22, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants