Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: case migration failed #478

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aagjalpankaj
Copy link

Steps To Reproduce

  1. Set AUTORUN_ENABLED="true".
  2. Write a Laravel migration that can fail.
  3. Deploy the application. The migration will fail, but the deployment will succeed.
    In such case, code changes will be deployed, but schema changes will not, which may break the application state.

Outcome

What did you expect?
Deployment should be rollbacked or should not succeed when migration fails

What happened instead?
Code changes deployed / Deployment succeeded

Affected Docker Images

I guess most of the images if people are using it for Laravel application with AUTORUN_ENABLED="true" option.


This PR fixes #477

@aagjalpankaj
Copy link
Author

@jaydrogers 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deployment succeeds when migration fails
1 participant