-
-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v3.4 Release #445
Merged
Merged
v3.4 Release #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
β¦ehavior (#437) * Add custom registry support to build command * Attempted fix for just-containers/s6-overlay#586 * Preprended `fpm` to debug logs * Revert change back to SIGQUIT for best performance with graceful shutdowns with FPM * fix fpm with custom command (#413) Co-authored-by: Jay Rogers <[email protected]> * Removed undefined PHP_VARIATION warnings * Added support for running custom commands * Improved debug notice * Added deprecation notice * Revert "Removed undefined PHP_VARIATION warnings" This reverts commit fbfcc9d. * Remove undefined variable warnings --------- Co-authored-by: Fabio Capucci <[email protected]>
* Added "runs-on" runner * Added Skip Download support * Testing runners with static versions * Changed to 4 CPUs * Revert back to pulling versions from PHP.net
jaydrogers
added
the
β‘οΈ Enhancement
Items that are new features requested to be added.
label
Sep 27, 2024
This comment was marked as off-topic.
This comment was marked as off-topic.
* Fix S6 error of "/package/admin/s6-overlay/libexec/preinit: info: /run belongs to uid 82 instead of 501 - fixing it" * Added native health checks for advanced Laravel services. Fixes #444 * Added documentation for health checks
This was referenced Oct 2, 2024
cappuc
reviewed
Oct 7, 2024
# Check if S6 is initialized | ||
if [ "$S6_INITIALIZED" != "true" ]; then | ||
echo "βΉοΈ [NOTICE]: S6 is not initialized. Skipping web server configuration and running custom command." | ||
exit 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be return 0
, with exit 0
subsequent scripts will not run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π¨βπ¬ Testing this PR
You can visit the serversideup/php-dev repo and view any item tagged with
445
. Each image will be rebuilt after a new commit is pushed to this PR.π Viewing the docs
The docs are continuously updated with the latest for this release. Visit the preview site below:
View the v3.4 Preview Site β
π― Project Board
If you'd like to see the status of where this project is, view the project board.
View the v3.4 GitHub Project Board β
π If you found a bug
Please report them on our GitHub issue tracker and specifically mention you're testing the v3.4 release.
Report a bug on GitHub β
π What's new
Here's a summary of what's new
π€© New Features
π Bug fixes
π Security Improvements
β« Dependency Updates
π€ Development improvements