Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure permissions on /run directory for compatibility with cloud providers #385

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

jaydrogers
Copy link
Member

What this PR does

  • Fixes permissions issues for running with Azure and Google Cloud Run
  • Fixes some CI/CD stuff for PRs

Related Discussions

Co-authored by

hajekj and others added 2 commits June 19, 2024 15:33
…providers with restricted container permissions (#376)

* Configure permissions on /run directory for compatibility with cloud providers with restricted container permissions.

Fixes #372, #360

* Configure permissions on /run directory for compatibility with cloud providers with restricted container permissions.

Fixes #372, #360

* Attempt to set target for running builds

* Configure permissions on /run directory for compatibility with cloud providers with restricted container permissions.

Fixes #372, #360

* Set /run to www-data:www-data

* Added comment

* Fixed logic of PR prefixes

* Change prefix to event name

* Set explicit files for running PR images

* Set pull request event

---------

Co-authored-by: Jay Rogers <[email protected]>
@jaydrogers
Copy link
Member Author

@hajekj: I have the images publishing now under my own branch. This should fix all the non-sense with GitHub Actions.

These tags will be prefixed with the PR number now.

Example:

docker.io/serversideup/php-dev:385-7.4.33-cli-alpine  
docker.io/serversideup/php-dev:385-7.4-cli-alpine  
docker.io/serversideup/php-dev:385-7.4-alpine  
docker.io/serversideup/php-dev:385-7-cli-alpine  
docker.io/serversideup/php-dev:385-7-alpine  

Once this is done, if you can confirm the changes are there and work that would be great.

I would test the following Operating System variations to be sure this works across the board:

  • Alpine
  • Bookworm
  • Bullseye

If this does not work

We can do the chown -R 755 as you initially proposed. I am just trying to take the "least privilege" route.

Thanks for your patience and dedication on this issue!

@hajekj
Copy link

hajekj commented Jun 19, 2024

That did the job - http://container-apps-test--jafwdzh.purplemoss-bcf270ea.westeurope.azurecontainerapps.io/

The image is now running in Azure just fine.

@jaydrogers
Copy link
Member Author

Sweet! Thanks for the update!

Did it work on the other operating systems too?

@hajekj
Copy link

hajekj commented Jun 19, 2024

The builds are now complete, so managed to test all of those you listed.

@jaydrogers jaydrogers merged commit 0dcdbf6 into main Jun 19, 2024
41 of 43 checks passed
@jaydrogers
Copy link
Member Author

Thanks a ton for your help @hajekj!

I have this merged and it will be released soon.

I might do a beta release with this one then merge it to stable later on.

@jaydrogers jaydrogers deleted the adjust-run-permissions-for-s6-overlay branch July 10, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants