Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 404 error in cloud instance delete #19

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Fix 404 error in cloud instance delete #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
680e16e
fix: allow 404 for instance during deletion
amarao Jan 19, 2024
20ffdf0
chore: bump version to 0.1.0
amarao Jan 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ansible_collections/serverscom/sc_api/galaxy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
namespace: serverscom
name: sc_api
version: 0.0.8
version: 0.1.0
readme: README.md
authors:
- George Shuklin <[email protected]>
Expand Down
4 changes: 4 additions & 0 deletions ansible_collections/serverscom/sc_api/plugins/module_utils/modules.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -629,6 +629,10 @@ def retry_to_delete(self, instance):
time.sleep(self.update_interval)
else:
raise
except APIError404:
# We expected to delete instance and it's gone
# == happy end
pass
instance = instance = self.api.toolbox.find_instance(
self.instance_id, self.name, self.region_id, must=False
)
Expand Down
Loading