Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: zip can contain directories and files at the root #11

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

jteulade
Copy link
Contributor

@jteulade jteulade commented Mar 7, 2024

Choose a zip with a file XXX and a directory at the root of the archive.
Try to use extract_file method, you get this error:
[Errno 21] Is a directory: 'XXX'
We should not consider the file as a directory.

@remi-braun
Copy link
Member

remi-braun commented Mar 8, 2024

Could you add:

  • a CI test (we'll see together next week)
  • a line in CHANGES.md about this bugfix

Copy link
Member

@remi-braun remi-braun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you detail a bit how your change makes the directory check working?
A could you skip a line before the comment? ;)

@remi-braun remi-braun merged commit 1d90f3a into master Mar 11, 2024
2 checks passed
@remi-braun remi-braun deleted the fix/extract_file_for_zip branch July 17, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants