Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/vapor/vapor from 4.106.0 to 4.106.1 #171

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 24, 2024

Bumps github.com/vapor/vapor from 4.106.0 to 4.106.1.

Release notes

Sourced from github.com/vapor/vapor's releases.

4.106.1 - Omit ACAO header instead of empty value

What's Changed

Omit ACAO header instead of empty value by @​grahamburgsma in #3243

For context, Vapor currently sends an empty Access-Control-Allow-Origin (ACAO) header when the origin does not match or is set to none.

We recently had a pentest done against our Vapor server and the tester reported the following regarding the empty ACAO header:

When the header is empty, browsers might reject the request without detailed error messages, making it harder for developers to debug or even realize there is a problem. This lack of transparency can lead to extended periods of vulnerability before the issue is discovered.

Looking at some other sources as well, an empty header doesn’t appear to be a valid value and so could result in unexpected behaviour.

https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS#the_http_response_headers https://fetch.spec.whatwg.org/#http-access-control-allow-origin

This patch was released by @​0xTim

Full Changelog: vapor/vapor@4.106.0...4.106.1

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/vapor/vapor](https://github.com/vapor/vapor) from 4.106.0 to 4.106.1.
- [Release notes](https://github.com/vapor/vapor/releases)
- [Commits](vapor/vapor@4.106.0...4.106.1)

---
updated-dependencies:
- dependency-name: github.com/vapor/vapor
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from ffried as a code owner October 24, 2024 05:18
@dependabot dependabot bot added dependencies Pull requests that update a dependency file swift_package_manager Pull requests that update Swift_package_manager code labels Oct 24, 2024
@github-actions github-actions bot enabled auto-merge (rebase) October 24, 2024 05:18
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.51%. Comparing base (4f9fa20) to head (bcf67bf).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #171      +/-   ##
==========================================
+ Coverage   33.47%   34.51%   +1.05%     
==========================================
  Files           9        9              
  Lines         753      962     +209     
==========================================
+ Hits          252      332      +80     
- Misses        501      630     +129     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot merged commit 099c6f0 into main Oct 24, 2024
22 checks passed
@github-actions github-actions bot deleted the dependabot/swift/github.com/vapor/vapor-4.106.1 branch October 24, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file swift_package_manager Pull requests that update Swift_package_manager code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant