Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/vapor/vapor from 4.101.0 to 4.101.1 #146

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 30, 2024

Bumps github.com/vapor/vapor from 4.101.0 to 4.101.1.

Release notes

Sourced from github.com/vapor/vapor's releases.

4.101.1 - Exclude Query and Fragment from URI semicolon fix on Linux

On Linux, URLComponents does not have 100% the same behavior like on macOS. Vapor accounts for this unfixed bug by replacing percent-encoded semicolon %3B with ; in URIs.

This is however not fully correct, because if a URI contains a percent encoded semicolon, this might have a different meaning, than when it is not percent encoded, compare the following sentence from RFC 3986:

A percent-encoding mechanism is used to represent a data octet in a
component when that octet's corresponding character is outside the
allowed set or is being used as a delimiter of, or within, the component.

This PR aims to limit the impact of the required semicolon fix by ensuring that query and fragments are not unnecessarily and incorrectly modified.

Hopefully, in a future with the new swift-foundation this fix will not be needed anymore. But for now it would solve an issue on our side which is related to the concept of a signed request.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/vapor/vapor](https://github.com/vapor/vapor) from 4.101.0 to 4.101.1.
- [Release notes](https://github.com/vapor/vapor/releases)
- [Commits](vapor/vapor@4.101.0...4.101.1)

---
updated-dependencies:
- dependency-name: github.com/vapor/vapor
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label May 30, 2024
@dependabot dependabot bot requested a review from ffried as a code owner May 30, 2024 05:54
@dependabot dependabot bot added the swift_package_manager Pull requests that update Swift_package_manager code label May 30, 2024
@github-actions github-actions bot enabled auto-merge (rebase) May 30, 2024 05:54
Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.47%. Comparing base (d7d1658) to head (5dfb2a6).
Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #146   +/-   ##
=======================================
  Coverage   33.47%   33.47%           
=======================================
  Files           9        9           
  Lines         753      753           
=======================================
  Hits          252      252           
  Misses        501      501           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot merged commit 46efb04 into main Jun 3, 2024
17 checks passed
@github-actions github-actions bot deleted the dependabot/swift/github.com/vapor/vapor-4.101.1 branch June 3, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file swift_package_manager Pull requests that update Swift_package_manager code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant