Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/vapor/vapor from 4.94.0 to 4.94.1 #135

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 29, 2024

Bumps github.com/vapor/vapor from 4.94.0 to 4.94.1.

Release notes

Sourced from github.com/vapor/vapor's releases.

4.94.1 - Patch configuration and log actual port on startup

What's Changed

Patch configuration and log actual port on startup by @​bisgardo in #3160

Before this change, the application

let app = Application(.testing)
defer { app.shutdown() }
try app.server.start(hostname: nil, port: 0)
defer { app.server.shutdown() }

would log the following message before starting the server:

[Vapor] Server starting on http://127.0.0.1:0

After this change it instead logs a message like the following after starting the server:

[Vapor] Server starting on http://127.0.0.1:57935

The input configuration is also patched such that app.http.server.configuration.port will hold the actual port after startup. Currently if it has value 0 it will keep that value (only app.http.server.shared.localAddress?.port will have the correct one).

Fixes #3159.

Reviewers

Thanks to the reviewers for their help:

This patch was released by @​0xTim

Full Changelog: vapor/vapor@4.94.0...4.94.1

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/vapor/vapor](https://github.com/vapor/vapor) from 4.94.0 to 4.94.1.
- [Release notes](https://github.com/vapor/vapor/releases)
- [Commits](vapor/vapor@4.94.0...4.94.1)

---
updated-dependencies:
- dependency-name: github.com/vapor/vapor
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from ffried as a code owner April 29, 2024 05:19
@dependabot dependabot bot added dependencies Pull requests that update a dependency file swift_package_manager Pull requests that update Swift_package_manager code labels Apr 29, 2024
@github-actions github-actions bot enabled auto-merge (rebase) April 29, 2024 05:19
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.47%. Comparing base (d7d1658) to head (8210721).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #135   +/-   ##
=======================================
  Coverage   33.47%   33.47%           
=======================================
  Files           9        9           
  Lines         753      753           
=======================================
  Hits          252      252           
  Misses        501      501           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot merged commit 801da87 into main Apr 29, 2024
17 checks passed
@github-actions github-actions bot deleted the dependabot/swift/github.com/vapor/vapor-4.94.1 branch April 29, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file swift_package_manager Pull requests that update Swift_package_manager code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant