Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/vapor/vapor from 4.89.1 to 4.89.3 #119

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 14, 2023

Bumps github.com/vapor/vapor from 4.89.1 to 4.89.3.

Release notes

Sourced from github.com/vapor/vapor's releases.

4.89.3 - Fix setting public folder for FileMiddleware when using bundles

What's Changed

Fix setting public folder for FileMiddleware when using bundles by @​grantjbutler in #3113

This PR fixes an issue where, if you provided a subfolder within a bundle’s resources, the wrong path would be provided to the FileMiddleware, causing the resources to not be loaded.

For example, given a bundle with the following structure:

App.app/
└── Contents/
    ├── MacOS/
    │   └── App
    └── Resources/
        └── web-app/
            └── Public
                └── index.html

If you tried to create an instance of FileMiddleware that tried to use web-app/Public/ as the folder to serve files from, FileMiddleware would incorrectly use the resource path of the bundle (App.app/Resources/) instead of the full path to the specified folder (App.app/Resources/web-app/Public/).

New Contributor

This patch was released by @​gwynne

Full Changelog: vapor/vapor@4.89.2...4.89.3

4.89.2 - Consistently use the value from X-Request-Id as the request's ID when present

What's Changed

Consistently use the value from X-Request-Id as the request's ID when present by @​baarde in #3117

Changes

This PR ensures that the Request’s id and the value of the logger’s request-id value are the same.

Motivation

The Request’s id property was added in #2964 to expose the request-id identifier used for logging.

#3072 changed this behavior. The request-id identifier is now set:

  • to the value from the X-Request-Id header, when the header is present,
  • to a random identifier, when the header is absent.

Having two different identifiers is confusing. So, this PR reconciles the two values.

History

... (truncated)

Commits
  • 67fe736 Fix setting public folder for FileMiddleware when using bundles (#3113)
  • 9c830d4 Consistently use the value from X-Request-Id as the request's ID when prese...
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/vapor/vapor](https://github.com/vapor/vapor) from 4.89.1 to 4.89.3.
- [Release notes](https://github.com/vapor/vapor/releases)
- [Commits](vapor/vapor@4.89.1...4.89.3)

---
updated-dependencies:
- dependency-name: github.com/vapor/vapor
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from ffried as a code owner December 14, 2023 06:27
@dependabot dependabot bot added dependencies Pull requests that update a dependency file swift_package_manager Pull requests that update Swift_package_manager code labels Dec 14, 2023
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c5aac0e) 34.73% compared to head (72f7bf0) 34.73%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #119   +/-   ##
=======================================
  Coverage   34.73%   34.73%           
=======================================
  Files           9        9           
  Lines         956      956           
=======================================
  Hits          332      332           
  Misses        624      624           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ffried ffried enabled auto-merge (rebase) December 15, 2023 09:55
@ffried ffried merged commit 024a235 into main Dec 15, 2023
10 of 11 checks passed
@ffried ffried deleted the dependabot/swift/github.com/vapor/vapor-4.89.3 branch December 15, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file swift_package_manager Pull requests that update Swift_package_manager code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant