blsforme: Temporarily force quiet for Serpent testing #271
reviewdog [clippy] report
reported by reviewdog 🐶
Findings (6)
crates/topology/src/disk/mounts.rs|35 col 6| warning: the following explicit lifetimes could be elided: 'a
--> crates/topology/src/disk/mounts.rs:35:6
|
35 | impl<'a> MountOption<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: #[warn(clippy::needless_lifetimes)]
on by default
help: elide the lifetimes
|
35 - impl<'a> MountOption<'a> {
35 + impl MountOption<'> {
|
crates/topology/src/disk/mounts.rs|50 col 6| warning: the following explicit lifetimes could be elided: 'a
--> crates/topology/src/disk/mounts.rs:50:6
|
50 | impl<'a> Mount<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
50 - impl<'a> Mount<'a> {
50 + impl Mount<'> {
|
crates/topology/src/disk/probe.rs|60 col 35| warning: unnecessary closure used to substitute value for Option::None
--> crates/topology/src/disk/probe.rs:60:35
|
60 | let matching_device = self
| ___________________________________^
61 | | .mounts
62 | | .iter()
63 | | .find(|m| PathBuf::from(m.mountpoint) == mountpoint)
64 | | .ok_or_else(|| super::Error::UnknownMount(mountpoint))?;
| |_____________________________________________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
= note: #[warn(clippy::unnecessary_lazy_evaluations)]
on by default
help: use ok_or
instead
|
64 | .ok_or(super::Error::UnknownMount(mountpoint))?;
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
blsforme/src/bootloader/systemd_boot/mod.rs|23 col 12| warning: field config
is never read
--> blsforme/src/bootloader/systemd_boot/mod.rs:25:5
|
23 | pub struct Loader<'a, 'b> {
| ------ field in this struct
24 | /// system configuration
25 | config: &'a Configuration,
| ^^^^^^
|
= note: Loader
has a derived impl for the trait Debug
, but this is intentionally ignored during dead code analysis
= note: #[warn(dead_code)]
on by default
blsforme/src/entry.rs|10 col 12| warning: field cmdline
is never read
--> blsforme/src/entry.rs:14:5
|
10 | pub struct Entry<'a> {
| ----- field in this struct
...
14 | cmdline: Option,
| ^^^^^^^
|
= note: Entry
has a derived impl for the trait Debug
, but this is intentionally ignored during dead code analysis
blsforme/src/kernel.rs|102 col 6| warning: the following explicit lifetimes could be elided: 'a
--> blsforme/src/kernel.rs:102:6
|
102 | impl<'a> Schema<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: #[warn(clippy::needless_lifetimes)]
on by default
help: elide the lifetimes
|
102 - impl<'a> Schema<'a> {
102 + impl Schema<'> {
|
Filtered Findings (0)
Annotations
Check warning on line 35 in crates/topology/src/disk/mounts.rs
github-actions / clippy
[clippy] crates/topology/src/disk/mounts.rs#L35
warning: the following explicit lifetimes could be elided: 'a
--> crates/topology/src/disk/mounts.rs:35:6
|
35 | impl<'a> MountOption<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
35 - impl<'a> MountOption<'a> {
35 + impl MountOption<'_> {
|
Raw output
crates/topology/src/disk/mounts.rs:35:6:w:warning: the following explicit lifetimes could be elided: 'a
--> crates/topology/src/disk/mounts.rs:35:6
|
35 | impl<'a> MountOption<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
35 - impl<'a> MountOption<'a> {
35 + impl MountOption<'_> {
|
__END__
Check warning on line 50 in crates/topology/src/disk/mounts.rs
github-actions / clippy
[clippy] crates/topology/src/disk/mounts.rs#L50
warning: the following explicit lifetimes could be elided: 'a
--> crates/topology/src/disk/mounts.rs:50:6
|
50 | impl<'a> Mount<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
50 - impl<'a> Mount<'a> {
50 + impl Mount<'_> {
|
Raw output
crates/topology/src/disk/mounts.rs:50:6:w:warning: the following explicit lifetimes could be elided: 'a
--> crates/topology/src/disk/mounts.rs:50:6
|
50 | impl<'a> Mount<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
50 - impl<'a> Mount<'a> {
50 + impl Mount<'_> {
|
__END__
Check warning on line 60 in crates/topology/src/disk/probe.rs
github-actions / clippy
[clippy] crates/topology/src/disk/probe.rs#L60
warning: unnecessary closure used to substitute value for `Option::None`
--> crates/topology/src/disk/probe.rs:60:35
|
60 | let matching_device = self
| ___________________________________^
61 | | .mounts
62 | | .iter()
63 | | .find(|m| PathBuf::from(m.mountpoint) == mountpoint)
64 | | .ok_or_else(|| super::Error::UnknownMount(mountpoint))?;
| |______________________________________________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
= note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default
help: use `ok_or` instead
|
64 | .ok_or(super::Error::UnknownMount(mountpoint))?;
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Raw output
crates/topology/src/disk/probe.rs:60:35:w:warning: unnecessary closure used to substitute value for `Option::None`
--> crates/topology/src/disk/probe.rs:60:35
|
60 | let matching_device = self
| ___________________________________^
61 | | .mounts
62 | | .iter()
63 | | .find(|m| PathBuf::from(m.mountpoint) == mountpoint)
64 | | .ok_or_else(|| super::Error::UnknownMount(mountpoint))?;
| |______________________________________________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
= note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default
help: use `ok_or` instead
|
64 | .ok_or(super::Error::UnknownMount(mountpoint))?;
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
__END__
Check warning on line 23 in blsforme/src/bootloader/systemd_boot/mod.rs
github-actions / clippy
[clippy] blsforme/src/bootloader/systemd_boot/mod.rs#L23
warning: field `config` is never read
--> blsforme/src/bootloader/systemd_boot/mod.rs:25:5
|
23 | pub struct Loader<'a, 'b> {
| ------ field in this struct
24 | /// system configuration
25 | config: &'a Configuration,
| ^^^^^^
|
= note: `Loader` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
= note: `#[warn(dead_code)]` on by default
Raw output
blsforme/src/bootloader/systemd_boot/mod.rs:23:12:w:warning: field `config` is never read
--> blsforme/src/bootloader/systemd_boot/mod.rs:25:5
|
23 | pub struct Loader<'a, 'b> {
| ------ field in this struct
24 | /// system configuration
25 | config: &'a Configuration,
| ^^^^^^
|
= note: `Loader` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
= note: `#[warn(dead_code)]` on by default
__END__
Check warning on line 10 in blsforme/src/entry.rs
github-actions / clippy
[clippy] blsforme/src/entry.rs#L10
warning: field `cmdline` is never read
--> blsforme/src/entry.rs:14:5
|
10 | pub struct Entry<'a> {
| ----- field in this struct
...
14 | cmdline: Option<String>,
| ^^^^^^^
|
= note: `Entry` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
Raw output
blsforme/src/entry.rs:10:12:w:warning: field `cmdline` is never read
--> blsforme/src/entry.rs:14:5
|
10 | pub struct Entry<'a> {
| ----- field in this struct
...
14 | cmdline: Option<String>,
| ^^^^^^^
|
= note: `Entry` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
__END__
Check warning on line 102 in blsforme/src/kernel.rs
github-actions / clippy
[clippy] blsforme/src/kernel.rs#L102
warning: the following explicit lifetimes could be elided: 'a
--> blsforme/src/kernel.rs:102:6
|
102 | impl<'a> Schema<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
102 - impl<'a> Schema<'a> {
102 + impl Schema<'_> {
|
Raw output
blsforme/src/kernel.rs:102:6:w:warning: the following explicit lifetimes could be elided: 'a
--> blsforme/src/kernel.rs:102:6
|
102 | impl<'a> Schema<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
102 - impl<'a> Schema<'a> {
102 + impl Schema<'_> {
|
__END__