Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Replace firefly with scotty in tests #305

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

int-index
Copy link
Member

Problem: firefly depends on regex-pcre, which fails to build in certain configurations:

  regex-pcre > regex-pcre-0.95.0.0: library-dirs: /usr/lib is a relative path which makes no
  regex-pcre > sense (as there is nothing for it to be relative to). You can make paths
  regex-pcre > relative to the package database itself by using ${pkgroot}. (use --force to
  regex-pcre > override)
  regex-pcre > regex-pcre-0.95.0.0: dynamic-library-dirs: /usr/lib is a relative path which
  regex-pcre > makes no sense (as there is nothing for it to be relative to). You can make
  regex-pcre > paths relative to the package database itself by using ${pkgroot}. (use
  regex-pcre > --force to override)

The problem only occurs with stack on Windows. Therefore, there are two possible workarounds: (a) use cabal, (b) drop Windows support. However, we would like to support both build tools on all platforms if possible.

Solution: replace firefly with scotty, a different web server library that does not depend on regex-pcre.

@serokell-bot
Copy link
Contributor

1 Warning
⚠️ Bad issue ID in branch name.
Valid format for issue IDs: #123 or chore.

Generated by 🚫 Danger

Problem: `firefly` depends on `regex-pcre`, which fails to build in
certain configurations:

  regex-pcre > regex-pcre-0.95.0.0: library-dirs: /usr/lib is a relative path which makes no
  regex-pcre > sense (as there is nothing for it to be relative to). You can make paths
  regex-pcre > relative to the package database itself by using ${pkgroot}. (use --force to
  regex-pcre > override)
  regex-pcre > regex-pcre-0.95.0.0: dynamic-library-dirs: /usr/lib is a relative path which
  regex-pcre > makes no sense (as there is nothing for it to be relative to). You can make
  regex-pcre > paths relative to the package database itself by using ${pkgroot}. (use
  regex-pcre > --force to override)

The problem only occurs with `stack` on Windows. Therefore, there are
two possible workarounds: (a) use `cabal`, (b) drop Windows support.
However, we would like to support both build tools on all platforms if
possible.

Solution: replace `firefly` with `scotty`, a different web server
library that does not depend on `regex-pcre`.
@int-index int-index merged commit 7d43d9c into int-index/lts-22 Oct 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants