refactor: cleanup #348
Merged
refactor: cleanup #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jacob Nguyen <[email protected]>
|
Removed the localization feature of this branch. this has turned into a refactor branch. |
jacoobes
approved these changes
Feb 8, 2024
|
ready to merge? |
|
By at least tomorrow, this might be a patch I gotta review it again
Vào Th 5, 8 thg 2, 2024 lúc 12:31 CH SrIzan10 ***@***.***> đã
viết:
… ready to merge?
—
Reply to this email directly, view it on GitHub
<#348 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASJS6O6IWX4VF3JBTGH2TTTYSUKYTAVCNFSM6AAAAABBNN3JGWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZUG4YTCOBVHE>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
SrIzan10
commented
Feb 8, 2024
|
@SrIzan10 rereview, I think everything will be alright |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR features basic refactoring and cleaning up.
Users may receive some errors if they were using SernEmitter directly. This class has been removed