Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

router plugins support springboot3 & fix an issue where inputstream is sometimes lost. #1691

Closed
wants to merge 2 commits into from

Conversation

provenceee
Copy link
Collaborator

What type of PR is this?

Bug&Feature

What this PR does / why we need it?

router plugin does not support springboot3

fix an issue where inputstream is sometimes lost.

Which issue(s) this PR fixes?

Fixes #1646 #1669

Does this PR introduce a user-facing change?

No

Checklist

  • Make sure there is a GitHub_issue related with this PR before you start working on it.
  • Make sure you have squashed your change to one single commit.
  • GitHub Actions works fine in this PR.

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 60.79295% with 89 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...mant/flowcontrol/DispatcherServletInterceptor.java 45.09% 27 Missing and 1 partial ⚠️
...ace/interceptors/DispatcherServletInterceptor.java 63.63% 14 Missing and 6 partials ⚠️
...itor/interceptor/DispatcherServletInterceptor.java 0.00% 16 Missing ⚠️
...ring/interceptor/DispatcherServletInterceptor.java 76.56% 12 Missing and 3 partials ⚠️
...sermant/router/spring/utils/SpringRouterUtils.java 61.53% 5 Missing ⚠️
...try/grace/declarers/DispatcherServletDeclarer.java 0.00% 3 Missing ⚠️
...interceptor/AbstractHandlerMappingInterceptor.java 81.81% 1 Missing and 1 partial ⚠️
Flag Coverage Δ Complexity Δ
unittests 44.09% <60.79%> (-0.09%) 181.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ Complexity Δ
...rmant/loadbalancer/interceptor/UrlInterceptor.java 76.00% <ø> (ø) 0.00 <0.00> (ø)
...t/loadbalancer/declarer/ClientFactoryDeclarer.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
.../ServiceDiscoveryRegistryDirectoryInterceptor.java 75.00% <ø> (ø) 2.00 <0.00> (ø)
...ter/spring/declarer/DispatcherServletDeclarer.java 0.00% <ø> (ø) 0.00 <0.00> (?)
...ain/java/io/sermant/router/spring/entity/Keys.java 100.00% <100.00%> (ø) 0.00 <0.00> (?)
...sermant/router/spring/handler/AbstractHandler.java 88.88% <ø> (ø) 0.00 <0.00> (ø)
.../io/sermant/router/spring/handler/LaneHandler.java 88.88% <100.00%> (ø) 0.00 <0.00> (?)
...a/io/sermant/router/spring/handler/TagHandler.java 100.00% <100.00%> (ø) 0.00 <0.00> (?)
...pring/interceptor/DiscoveryManagerInterceptor.java 87.50% <100.00%> (-6.25%) 0.00 <0.00> (ø)
...pring/interceptor/EurekaHttpClientInterceptor.java 91.66% <100.00%> (ø) 0.00 <0.00> (ø)
... and 11 more

... and 1 file with indirect coverage changes

@provenceee provenceee closed this Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant