Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore tag injection when the key exists #1677

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

lilai23
Copy link
Collaborator

@lilai23 lilai23 commented Nov 19, 2024

What type of PR is this?

Bug

What this PR does / why we need it?

ignore tag injection when the key exists

Which issue(s) this PR fixes?

Fixes #1674

Does this PR introduce a user-facing change?

No

Checklist

  • Make sure there is a GitHub_issue related with this PR before you start working on it.
  • Make sure you have squashed your change to one single commit.
  • GitHub Actions works fine in this PR.

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 32.50000% with 27 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ion/okhttpv2/interceptors/OkHttp2xInterceptor.java 50.00% 1 Missing and 2 partials ⚠️
.../interceptors/AlibabaDubboConsumerInterceptor.java 33.33% 1 Missing and 1 partial ⚠️
...2/interceptors/ApacheDubboConsumerInterceptor.java 33.33% 1 Missing and 1 partial ⚠️
...3/interceptors/ApacheDubboConsumerInterceptor.java 33.33% 1 Missing and 1 partial ⚠️
...n/grpc/interceptors/ClientCallImplInterceptor.java 33.33% 1 Missing and 1 partial ⚠️
...clientv3/interceptors/HttpClient3xInterceptor.java 33.33% 1 Missing and 1 partial ⚠️
...clientv4/interceptors/HttpClient4xInterceptor.java 33.33% 1 Missing and 1 partial ⚠️
...jdkhttp/interceptors/JdkHttpClientInterceptor.java 33.33% 1 Missing and 1 partial ⚠️
...n/kafka/interceptors/KafkaProducerInterceptor.java 33.33% 1 Missing and 1 partial ⚠️
.../interceptors/RocketmqProducerSendInterceptor.java 0.00% 1 Missing and 1 partial ⚠️
... and 3 more
Flag Coverage Δ Complexity Δ
unittests 43.88% <32.50%> (-0.08%) 181.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ Complexity Δ
.../interceptors/AlibabaDubboConsumerInterceptor.java 64.00% <33.33%> (-4.19%) 0.00 <0.00> (ø)
...2/interceptors/ApacheDubboConsumerInterceptor.java 64.00% <33.33%> (-4.19%) 0.00 <0.00> (ø)
...3/interceptors/ApacheDubboConsumerInterceptor.java 64.00% <33.33%> (-4.19%) 0.00 <0.00> (ø)
...n/grpc/interceptors/ClientCallImplInterceptor.java 66.66% <33.33%> (-4.17%) 0.00 <0.00> (ø)
...clientv3/interceptors/HttpClient3xInterceptor.java 56.00% <33.33%> (-3.10%) 0.00 <0.00> (ø)
...clientv4/interceptors/HttpClient4xInterceptor.java 57.69% <33.33%> (-3.18%) 0.00 <0.00> (ø)
...jdkhttp/interceptors/JdkHttpClientInterceptor.java 51.51% <33.33%> (-1.82%) 0.00 <0.00> (ø)
...n/kafka/interceptors/KafkaProducerInterceptor.java 59.25% <33.33%> (-3.25%) 0.00 <0.00> (ø)
.../interceptors/RocketmqProducerSendInterceptor.java 63.33% <0.00%> (-4.53%) 0.00 <0.00> (ø)
...5/interceptor/RocketmqProducerSendInterceptor.java 63.33% <0.00%> (-4.53%) 0.00 <0.00> (ø)
... and 3 more

... and 27 files with indirect coverage changes

@lilai23 lilai23 changed the title 【fix】ignore tag injection when the key exists fix: ignore tag injection when the key exists Nov 21, 2024
@Sherlockhan Sherlockhan merged commit 9f81370 into sermant-io:develop Nov 26, 2024
83 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The sermant-tag-transmission plugin may repeatedly add request headers.
4 participants