-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
database write prohibition integration: mongodb and mysql action #1473
Merged
Sherlockhan
merged 1 commit into
sermant-io:develop
from
daizhenyu:develop-database-write-prohibition-integration
Mar 21, 2024
Merged
database write prohibition integration: mongodb and mysql action #1473
Sherlockhan
merged 1 commit into
sermant-io:develop
from
daizhenyu:develop-database-write-prohibition-integration
Mar 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1473 +/- ##
=============================================
- Coverage 43.40% 43.39% -0.02%
+ Complexity 4650 4647 -3
=============================================
Files 1231 1234 +3
Lines 26382 26391 +9
Branches 2755 2755
=============================================
+ Hits 11452 11453 +1
- Misses 13552 13560 +8
Partials 1378 1378
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
lilai23
reviewed
Mar 18, 2024
.github/actions/scenarios/database-write-prohibition/mongodb/action.yml
Outdated
Show resolved
Hide resolved
lilai23
reviewed
Mar 18, 2024
lilai23
reviewed
Mar 18, 2024
.github/actions/scenarios/database-write-prohibition/mysql/action.yml
Outdated
Show resolved
Hide resolved
lilai23
reviewed
Mar 18, 2024
.github/workflows/database_write_prohibition_integration_test.yml
Outdated
Show resolved
Hide resolved
daizhenyu
force-pushed
the
develop-database-write-prohibition-integration
branch
from
March 19, 2024 02:00
d5002a9
to
9243eaa
Compare
lilai23
previously approved these changes
Mar 19, 2024
.github/actions/scenarios/database-write-prohibition/mysql/action.yml
Outdated
Show resolved
Hide resolved
.github/actions/scenarios/database-write-prohibition/mysql/action.yml
Outdated
Show resolved
Hide resolved
Signed-off-by: daizhenyu <[email protected]>
daizhenyu
force-pushed
the
develop-database-write-prohibition-integration
branch
from
March 20, 2024 01:27
9243eaa
to
dfda9cc
Compare
hanbingleixue
approved these changes
Mar 20, 2024
lilai23
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Integration Test
What this PR does / why we need it?
database write prohibition plugin integration test : mongodb and mysql action
Which issue(s) this PR fixes?
Fixes #1461
Does this PR introduce a user-facing change?
No
Checklist