Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set PluginClassLoader for plugin config #1465

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

lilai23
Copy link
Collaborator

@lilai23 lilai23 commented Mar 14, 2024

What type of PR is this?

Bug

What this PR does / why we need it?

Change all the classloaders for plugin config to Pluginclassloader

Which issue(s) this PR fixes?

Fixes #1464

Does this PR introduce a user-facing change?

No

Checklist

  • Make sure there is a GitHub_issue related with this PR before you start working on it.
  • Make sure you have squashed your change to one single commit.
  • GitHub Actions works fine in this PR.

@lilai23 lilai23 added kind/bug Something isn't working area/framework Issues or PRs releated to sermant core service labels Mar 14, 2024
@lilai23 lilai23 added this to the v1.4.0 milestone Mar 14, 2024
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 43.42%. Comparing base (d270273) to head (970fd59).
Report is 6 commits behind head on develop.

Files Patch % Lines
...ant/core/plugin/classloader/PluginClassLoader.java 0.00% 1 Missing ⚠️
...ermant/core/plugin/config/PluginConfigManager.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1465      +/-   ##
=============================================
- Coverage      44.06%   43.42%   -0.64%     
+ Complexity      4712     4649      -63     
=============================================
  Files           1231     1231              
  Lines          26382    26381       -1     
  Branches        2755     2754       -1     
=============================================
- Hits           11624    11455     -169     
- Misses         13370    13549     +179     
+ Partials        1388     1377      -11     
Flag Coverage Δ
unittests 43.42% <0.00%> (-0.64%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sherlockhan Sherlockhan merged commit 48ab598 into sermant-io:develop Mar 26, 2024
190 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/framework Issues or PRs releated to sermant core service kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

set PluginClassLoader for plugin config
4 participants