Modify metrics collection module. #1350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanbingleixue
added
kind/enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## cooperate-with-gala-gopher-alpha #1350 +/- ##
======================================================================
+ Coverage 42.22% 42.80% +0.58%
- Complexity 3270 3297 +27
======================================================================
Files 823 823
Lines 18303 18303
Branches 2017 2017
======================================================================
+ Hits 7728 7835 +107
+ Misses 9601 9484 -117
- Partials 974 984 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
daizhenyu
reviewed
Oct 31, 2023
...t-metrics/metrics-plugin/src/main/java/com/huawei/metrics/declarer/apache/CodecDeclarer.java
Outdated
Show resolved
Hide resolved
...s/metrics-plugin/src/main/java/com/huawei/metrics/interceptor/alibaba/FilterInterceptor.java
Outdated
Show resolved
Hide resolved
...ics/metrics-plugin/src/main/java/com/huawei/metrics/interceptor/apache/CodecInterceptor.java
Outdated
Show resolved
Hide resolved
...cs/metrics-plugin/src/main/java/com/huawei/metrics/interceptor/apache/FilterInterceptor.java
Outdated
Show resolved
Hide resolved
TangLeDaily
reviewed
Oct 31, 2023
...sermant-metrics/metrics-service/src/main/java/com/huawei/metrics/service/MetricsService.java
Outdated
Show resolved
Hide resolved
.../sermant-metrics/metrics-plugin/src/main/java/com/huawei/metrics/manager/MetricsManager.java
Outdated
Show resolved
Hide resolved
...ics/metrics-plugin/src/main/java/com/huawei/metrics/interceptor/apache/CodecInterceptor.java
Outdated
Show resolved
Hide resolved
...ics/metrics-plugin/src/main/java/com/huawei/metrics/interceptor/apache/CodecInterceptor.java
Outdated
Show resolved
Hide resolved
...cs/metrics-plugin/src/main/java/com/huawei/metrics/interceptor/alibaba/CodecInterceptor.java
Outdated
Show resolved
Hide resolved
hanbingleixue
force-pushed
the
develop
branch
from
4aa8ca3 to
d4236dc
Compare
TangLeDaily
previously approved these changes
Nov 2, 2023
daizhenyu
previously approved these changes
Nov 2, 2023
lilai23
reviewed
Nov 2, 2023
...cs-plugin/src/main/java/com/huawei/metrics/interceptor/alibaba/ExchangeCodecInterceptor.java
Outdated
Show resolved
Hide resolved
lilai23
reviewed
Nov 2, 2023
...cs/metrics-plugin/src/main/java/com/huawei/metrics/interceptor/AbstractCodecInterceptor.java
Outdated
Show resolved
Hide resolved
...cs-plugin/src/main/java/com/huawei/metrics/interceptor/alibaba/ExchangeCodecInterceptor.java
Outdated
Show resolved
Hide resolved
...cs/metrics-plugin/src/main/java/com/huawei/metrics/interceptor/AbstractCodecInterceptor.java
Outdated
Show resolved
Hide resolved
...sermant-metrics/metrics-service/src/main/java/com/huawei/metrics/service/MetricsService.java
Show resolved
Hide resolved
...sermant-metrics/metrics-service/src/main/java/com/huawei/metrics/service/MetricsService.java
Outdated
Show resolved
Hide resolved
hanbingleixue
dismissed stale reviews from daizhenyu and TangLeDaily
via
2f3442c
hanbingleixue
force-pushed
the
develop
branch
from
d4236dc to
2f3442c
Compare
luanwenfei-venus
previously approved these changes
Nov 6, 2023
hanbingleixue
force-pushed
the
develop
branch
from
2f3442c to
bec2992
Compare
lilai23
approved these changes
Nov 6, 2023
luanwenfei-venus
approved these changes
Nov 6, 2023
Sherlockhan
merged commit 81edb23
into
sermant-io:cooperate-with-gala-gopher-alpha
73 of 74 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Fix issue] #1341
[Modified content] Optimization indicator collection plug-in
[Use case description] 1. Subsequent supplementary test cases
[Self-test status] 1. Local static inspection and cleaning status; 2. Self-test passed
[Scope of impact] 1. Is there any impact on users’ use? 2. Subsequent supplementary usage documentation