Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bytecode enhancement ignores classes loaded by SermantClassLoader. #1349

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

hanbingleixue
Copy link
Collaborator

@hanbingleixue hanbingleixue commented Oct 27, 2023

[Fix issue] #1340

[Modification content] Ignore classes loaded by SermantClassLoader when bytecode is enhanced

[Use case description] No need to modify the use case

[Self-test status] 1. Local static inspection and cleaning status; 2. Self-test passed

[Scope of influence] 1. No impact on users’ use

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (63e8c97) 42.29% compared to head (53ab7b2) 43.12%.
Report is 24 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1349      +/-   ##
=============================================
+ Coverage      42.29%   43.12%   +0.82%     
- Complexity      3274     3346      +72     
=============================================
  Files            823      824       +1     
  Lines          18303    18587     +284     
  Branches        2014     2100      +86     
=============================================
+ Hits            7741     8015     +274     
+ Misses          9591     9584       -7     
- Partials         971      988      +17     
Flag Coverage Δ
unittests 43.12% <0.00%> (+0.82%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ermant/core/plugin/agent/BufferedAgentBuilder.java 0.00% <0.00%> (ø)

... and 26 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sherlockhan Sherlockhan merged commit 5cabdd9 into sermant-io:develop Oct 30, 2023
74 checks passed
@kkf1 kkf1 changed the title 字节码增强忽略SermantClassLoader加载的类 Bytecode enhancement ignores classes loaded by SermantClassLoader. Apr 13, 2024
@hanbingleixue hanbingleixue deleted the sermant-class-loader branch August 31, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants