Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSSE metrics collection. #1344

Merged

Conversation

hanbingleixue
Copy link
Collaborator

@hanbingleixue hanbingleixue commented Oct 20, 2023

【Fix issue】#1341

[Modification content] Added dubbo’s JSSE indicator collection

[Use case description] 1. Subsequent supplementary test cases

[Self-test status] 1. Local static inspection and cleaning status; 2. Self-test passed

[Scope of impact] 1. Is there any impact on users’ use? 2. Subsequent supplementary usage documentation

@hanbingleixue hanbingleixue changed the title 提交DUBBO指标采集 提交JSSE指标采集 Oct 20, 2023
@hanbingleixue hanbingleixue changed the title 提交JSSE指标采集 新增JSSE指标采集 Oct 20, 2023
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (240d958) 42.68% compared to head (c509a15) 42.22%.
Report is 25 commits behind head on cooperate-with-gala-gopher-alpha.

Additional details and impacted files
@@                          Coverage Diff                           @@
##             cooperate-with-gala-gopher-alpha    #1344      +/-   ##
======================================================================
- Coverage                               42.68%   42.22%   -0.47%     
+ Complexity                               3289     3270      -19     
======================================================================
  Files                                     823      823              
  Lines                                   18279    18303      +24     
  Branches                                 2007     2017      +10     
======================================================================
- Hits                                     7803     7728      -75     
- Misses                                   9503     9601      +98     
- Partials                                  973      974       +1     
Flag Coverage Δ
unittests 42.22% <ø> (-0.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 27 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hanbingleixue hanbingleixue force-pushed the develop branch 3 times, most recently from 14a6015 to 91e722a Compare October 20, 2023 07:05
@hanbingleixue hanbingleixue added kind/enhancement Issues or PRs releated to sermant enhancement area/plugin Issues or PRs releated to sermant plugin service labels Oct 20, 2023
daizhenyu
daizhenyu previously approved these changes Oct 20, 2023
@Sherlockhan Sherlockhan merged commit 40880b9 into sermant-io:cooperate-with-gala-gopher-alpha Oct 24, 2023
73 of 74 checks passed
@kkf1 kkf1 changed the title 新增JSSE指标采集 Add JSSE metrics collection. Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugin Issues or PRs releated to sermant plugin service kind/enhancement Issues or PRs releated to sermant enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants