-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JSSE metrics collection. #1344
Merged
Sherlockhan
merged 1 commit into
sermant-io:cooperate-with-gala-gopher-alpha
from
hanbingleixue:develop
Oct 24, 2023
Merged
Add JSSE metrics collection. #1344
Sherlockhan
merged 1 commit into
sermant-io:cooperate-with-gala-gopher-alpha
from
hanbingleixue:develop
Oct 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## cooperate-with-gala-gopher-alpha #1344 +/- ##
======================================================================
- Coverage 42.68% 42.22% -0.47%
+ Complexity 3289 3270 -19
======================================================================
Files 823 823
Lines 18279 18303 +24
Branches 2007 2017 +10
======================================================================
- Hits 7803 7728 -75
- Misses 9503 9601 +98
- Partials 973 974 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
hanbingleixue
force-pushed
the
develop
branch
3 times, most recently
from
October 20, 2023 07:05
14a6015
to
91e722a
Compare
hanbingleixue
added
kind/enhancement
Issues or PRs releated to sermant enhancement
area/plugin
Issues or PRs releated to sermant plugin service
labels
Oct 20, 2023
luanwenfei-venus
previously approved these changes
Oct 20, 2023
.../sermant-jsse/jsse-plugin/src/main/java/com/huawei/jsse/declarer/alibaba/DecodeDeclarer.java
Outdated
Show resolved
Hide resolved
...s/sermant-jsse/jsse-plugin/src/main/java/com/huawei/jsse/declarer/apache/DecodeDeclarer.java
Outdated
Show resolved
Hide resolved
...ant-jsse/jsse-plugin/src/main/java/com/huawei/jsse/interceptor/alibaba/CodecInterceptor.java
Outdated
Show resolved
Hide resolved
...ant-jsse/jsse-plugin/src/main/java/com/huawei/jsse/interceptor/alibaba/CodecInterceptor.java
Outdated
Show resolved
Hide resolved
...ant-jsse/jsse-plugin/src/main/java/com/huawei/jsse/interceptor/alibaba/CodecInterceptor.java
Outdated
Show resolved
Hide resolved
...nt-jsse/jsse-plugin/src/main/java/com/huawei/jsse/interceptor/alibaba/InvokeInterceptor.java
Outdated
Show resolved
Hide resolved
daizhenyu
reviewed
Oct 20, 2023
sermant-plugins/sermant-jsse/jsse-plugin/src/main/java/com/huawei/jsse/entity/JsseInfo.java
Show resolved
Hide resolved
...ant-jsse/jsse-plugin/src/main/java/com/huawei/jsse/interceptor/alibaba/CodecInterceptor.java
Show resolved
Hide resolved
...ant-plugins/sermant-jsse/jsse-service/src/main/java/com/huawei/jsse/service/JsseService.java
Show resolved
Hide resolved
daizhenyu
previously approved these changes
Oct 20, 2023
hanbingleixue
dismissed stale reviews from daizhenyu and luanwenfei-venus
via
October 20, 2023 10:01
c509a15
hanbingleixue
force-pushed
the
develop
branch
from
October 20, 2023 10:01
91e722a
to
c509a15
Compare
luanwenfei-venus
approved these changes
Oct 20, 2023
daizhenyu
approved these changes
Oct 23, 2023
Sherlockhan
merged commit Oct 24, 2023
40880b9
into
sermant-io:cooperate-with-gala-gopher-alpha
73 of 74 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/plugin
Issues or PRs releated to sermant plugin service
kind/enhancement
Issues or PRs releated to sermant enhancement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
【Fix issue】#1341
[Modification content] Added dubbo’s JSSE indicator collection
[Use case description] 1. Subsequent supplementary test cases
[Self-test status] 1. Local static inspection and cleaning status; 2. Self-test passed
[Scope of impact] 1. Is there any impact on users’ use? 2. Subsequent supplementary usage documentation