Traffic label transparent transmission test part demo #1328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1328 +/- ##
==========================================
Coverage 42.29% 42.29%
Complexity 3274 3274
==========================================
Files 823 823
Lines 18303 18303
Branches 2014 2014
==========================================
Hits 7741 7741
Misses 9591 9591
Partials 971 971
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
luanwenfei-venus
added
the
kind/enhancement
...-dubbo-consumer-demo/src/main/java/com/huaweicloud/demo/controller/AlibabaDubboConsumer.java
Outdated
Show resolved
Hide resolved
...-dubbo-consumer-demo/src/main/java/com/huaweicloud/demo/controller/AlibabaDubboConsumer.java
Outdated
Show resolved
Hide resolved
...mo/src/main/java/com/huaweicloud/demo/providerimpl/GreetingServiceAlibabaInnerDubboImpl.java
Outdated
Show resolved
Hide resolved
...der-demo/src/main/java/com/huaweicloud/demo/providerimpl/GreetingServiceApacheDubboImpl.java
Outdated
Show resolved
Hide resolved
.../tag-transmission-demo/alibaba-dubbo-provider-demo/src/main/resources/application.properties
Show resolved
Hide resolved
...-intergration-test/src/test/java/com/huaweicloud/intergration/common/utils/RequestUtils.java
Outdated
Show resolved
Hide resolved
...-intergration-test/src/test/java/com/huaweicloud/intergration/common/utils/RequestUtils.java
Outdated
Show resolved
Hide resolved
...emo/httpserver-jetty-demo/src/main/java/com/huaweicloud/demo/jetty/HttpJettyApplication.java
Outdated
Show resolved
Hide resolved
Comment on lines
1
to
15
| /* | ||
| * * Copyright (C) 2023-2023 Huawei Technologies Co., Ltd. All rights reserved. | ||
| * * | ||
| * * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * * you may not use this file except in compliance with the License. | ||
| * * You may obtain a copy of the License at | ||
| * * | ||
| * * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * * | ||
| * * Unless required by applicable law or agreed to in writing, software | ||
| * * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * * See the License for the specific language governing permissions and | ||
| * * limitations under the License. | ||
| */ |
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.huaweicloud.demo; |
There was a problem hiding this comment.
这个package为啥是com.huaweicloud.demo，建议包命名需要符合你的测试内容，避免最后demo这种泛化的名称所有人都使用
There was a problem hiding this comment.
并且，每个都归属于不同的module，建议包名符合自己的范围
daizhenyu
force-pushed
the
tag-transmission-demo
branch
from
9da4515 to
b82f339
Compare
daizhenyu
force-pushed
the
tag-transmission-demo
branch
from
b82f339 to
8c551ff
Compare
lilai23
reviewed
Oct 12, 2023
| * @since 2023-09-08 | ||
| **/ | ||
| @Service | ||
| public class GreetingServiceApacheDubboImpl implements AlibabaGreetingOuterService { |
There was a problem hiding this comment.
接口名是Alibaba，实现变成Apache，保持一致。如果接口名是alibaba和apache都要实现，那就起一个公共点的名字
lilai23
reviewed
Oct 12, 2023
| /** | ||
| * 流量标签的key值 | ||
| */ | ||
| public static final String[] TRAFFIC_TAG_KEY = {"id", "dynamic", "x-sermant-test", "tag-sermant"}; |
kkf1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
【Fix issue】#1244
[Modification content] Added some demo applications for traffic label transparent transmission, including alibaba dubbo demo, public httpserver demo and jetty server demo, used for traffic label transparent transmission plug-in integration testing
[Use case description] No
[Self-test situation] 1. Local static check passed
[Scope of influence] None