This repository has been archived by the owner on Mar 1, 2022. It is now read-only.
Added better error handling in LogglySink #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed a digit from the PackageReference for Serilog.Sinks.RollingFileAlternate in sampleDurableLogger.csproj to get local builds working.
Updated the EmitBatchAsync method in LogglySink to handle potential exceptions and evaluate the LogResponse when calling the Log method of the LogglyClient. It now writes to SelfLog when problems occur to enable easier debugging.
|
@nblumhardt or @MiguelAlho, just wondering if you've had a chance to look at this PR. I know life gets busy. 😄 |
nblumhardt
suggested changes
Aug 18, 2020
| break; | ||
| } | ||
| } | ||
| catch (Exception ex) |
There was a problem hiding this comment.
The exception shouldn't be caught here, but rather propagate up to Serilog (just removing the try/catch block here is fine).
There was a problem hiding this comment.
Done. Thanks for taking a look!
Removed the try/catch block in the EmitBatchAsync method of LogglySink to allow Serilog to handle exceptions centrally, based on PR feedback.
|
Thanks! 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the
EmitBatchAsyncmethod inLogglySinkto handle potential exceptions and evaluate theLogResponsewhen calling theLogmethod of theLogglyClient. It now writes toSelfLogwhen problems occur to enable easier debugging.I believe this may help with the problems described in #39.
Also removed a digit from the
PackageReferenceforSerilog.Sinks.RollingFileAlternatein sampleDurableLogger.csproj to get local builds working.