Removed try/catch block in LogglySink

Removed the try/catch block in the EmitBatchAsync method of LogglySink to allow Serilog to handle exceptions centrally, based on PR feedback.
serilog-archive · Aug 18, 2020 · f37a36c · f37a36c
1 parent 7073741
commit f37a36c
Showing 1 changed file with 8 additions and 15 deletions.
diff --git a/src/Serilog.Sinks.Loggly/Sinks/Loggly/LogglySink.cs b/src/Serilog.Sinks.Loggly/Sinks/Loggly/LogglySink.cs
@@ -81,23 +81,16 @@ public LogglySink(IFormatProvider formatProvider, int batchSizeLimit, TimeSpan p
         /// not both.</remarks>
         protected override async Task EmitBatchAsync(IEnumerable<LogEvent> events)
         {
-            try
-            {
-                LogResponse response = await _client.Log(events.Select(_converter.CreateLogglyEvent)).ConfigureAwait(false);
+            LogResponse response = await _client.Log(events.Select(_converter.CreateLogglyEvent)).ConfigureAwait(false);
 
-                switch (response.Code)
-                {
-                    case ResponseCode.Error:
-                        SelfLog.WriteLine("LogglySink received an Error response: {0}", response.Message);
-                        break;
-                    case ResponseCode.Unknown:
-                        SelfLog.WriteLine("LogglySink received an Unknown response: {0}", response.Message);
-                        break;
-                }
-            }
-            catch (Exception ex)
+            switch (response.Code)
             {
-                SelfLog.WriteLine("LogglySink encountered an exception: {0}", ex);
+                case ResponseCode.Error:
+                    SelfLog.WriteLine("LogglySink received an Error response: {0}", response.Message);
+                    break;
+                case ResponseCode.Unknown:
+                    SelfLog.WriteLine("LogglySink received an Unknown response: {0}", response.Message);
+                    break;
             }
         }