Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added serializer for django rest framework #28

Merged
merged 4 commits into from
Jul 15, 2020

Conversation

b0lle
Copy link
Contributor

@b0lle b0lle commented May 1, 2020

this is how I use your package with django rest framework. Hope this helps someone to avoid create them hisself. Thanks for your package!

@sergioteula sergioteula self-assigned this May 4, 2020
@sergioteula sergioteula added the feature New feature or request label May 4, 2020
@sergioteula
Copy link
Owner

Hello, thanks a lot for sharing your code. I'm not very familiar with django, could you please explain a bit how this works and how is integrated with the API? It would be more convenient for me to understand it before merging to master and adding it to documentation. Thanks again!

@YPCrumble
Copy link
Contributor

This is cool! What would be awesome is to also have a fixture for the AMZN response that we could use for testing this and other parts of this repo per #15. @b0lle if you have this in your serializers any way you could use Django fixtures to create a JSON fixture file from one of your model instances?

@b0lle
Copy link
Contributor Author

b0lle commented May 4, 2020

I can update the Readme file to give an example how to use serializers.

I can also provide a JSON file with serialized data. I would avoid a Django fixture because my database models do not store all fields available through this API. In my opinion there should be a test folder with an extra data folder. This is what I can create „tests/data“. Any other suggestions?

@sergioteula
Copy link
Owner

Thanks a lot for your help, that would be perfect. Once ready I will review and merge.

@b0lle
Copy link
Contributor Author

b0lle commented May 4, 2020

The updates are pushed. I changed the location of the 'serializers' folder to be a part of the installed package. Hope thats in your mind.

@sergioteula sergioteula merged commit 951341a into sergioteula:master Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants