New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't try to minify a BinaryFileResponse #1

Open

eab-andy wants to merge 1 commit into sergeysemko:master from eab-dev:FixBinaryFileResponse

eab-andy commented Dec 15, 2015

Don't try to minify a BinaryFileResponse, otherwise you will get the error:

"LogicException(code: 0): The content cannot be set on a BinaryFileResponse instance"


          Don't try to minify a BinaryFileResponse

ba979fc

fritzmg commented Aug 4, 2016

The same problem happens with a StreamedResponse:

LogicException: "The content cannot be set on a StreamedResponse instance."

So it should be

if ( $response instanceof BinaryFileResponse ||
     $response instanceof StreamedResponse )
    return;

I think those are the only two Response types where the content cannot be set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet