drop python<=3.7 support #2193
Open
drop python<=3.7 support #2193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to https://endoflife.date/python python 3.7 has been EOSed 27 Jun 2023. Filter all code over `pyupgrade --py38-plus`. Signed-off-by: Tomasz Kłoczko <[email protected]>
Signed-off-by: Tomasz Kłoczko <[email protected]>
serge-sans-paille
requested changes
Apr 3, 2024
There was a problem hiding this comment.
I'm fine with most changes - thanks for going through this. Please just don't change the papers/* files, they are associated with published papers and should stay as they are.
I've mentioned using more f-strings instead of sometimes using the format method, don't feel obliged to do so, that can be left for another round.
| @@ -43,8 +43,8 @@ def n_queens(queen_count): | |||
| cols = range(queen_count) | |||
| #for vec in permutations(cols): | |||
| for vec in permutations(cols,None): | |||
| if (queen_count == len(set(vec[i]+i for i in cols)) | |||
There was a problem hiding this comment.
don't touch the input of paper examples.
| @@ -69,7 +68,7 @@ def inline(self): | |||
| if tp_decl is None: | |||
| return tp_lines | |||
| else: | |||
| return "%s %s" % (tp_lines, tp_decl) | |||
| return "{} {}".format(tp_lines, tp_decl) | |||
There was a problem hiding this comment.
why not using fstrings here too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://endoflife.date/python python 3.7 has been EOSed 27 Jun 2023.
Filter all code over
pyupgrade --py38-plus.