Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse id arguments as their mentions where appropriate #315

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Parse id arguments as their mentions where appropriate #315

merged 2 commits into from
Oct 22, 2024

Conversation

jamesbt365
Copy link
Member

@jamesbt365 jamesbt365 commented Oct 22, 2024 •
edited
Loading

Fixes #274.

@jamesbt365 jamesbt365 requested a review from GnomedDev October 22, 2024 17:03
@jamesbt365 jamesbt365 requested a review from GnomedDev October 22, 2024 19:23
GnomedDev
GnomedDev approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@GnomedDev GnomedDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect now!

@GnomedDev GnomedDev merged commit bbc837a into serenity-rs:current Oct 22, 2024
12 checks passed
@jamesbt365 jamesbt365 deleted the id-parse branch October 22, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GnomedDev GnomedDev GnomedDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot use *Id arguments like the full counterparts in prefix commands
2 participants
@jamesbt365 @GnomedDev