Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixs/3523 newpr #3527

Merged
merged 3 commits into from
Sep 8, 2024
Merged

Bugfixs/3523 newpr #3527

merged 3 commits into from
Sep 8, 2024

Conversation

eitzenbe
Copy link
Contributor

@eitzenbe eitzenbe commented Sep 8, 2024

redone the previous branch, now consisting of the following changes:

  1. added escapeHtmlTags to Formatter which is used in breadcrumbs to escape example parameters used in scenario titles (especially the < and > characters

Scenario Outline: This is a dummy title for

would as of now end up in breadcrumbs as "This is a dummy title for"

  1. using <#outputFormat 'HTML'> on some locations in the ftl files where such a title would cause a misformatting or "sucking" the param string. Also in the tables showing the example values if one of the values itself would be an html tag like for example:
    Examples:
    | value|
    |red|
    ||

would yield a table with no visible value in the second row

lastly the test code uses hamcrest for checking if file exists by checking if exists returns true, whereas hamcrest suggest to use the anExistingFile() method approach

t.eitzenberger added 3 commits September 3, 2024 17:28
…tes or lt/gt tags in the title. Titles like "Test access to "<color>"" caused strange effects on the report (data-order attribute got unbound by the quotes, <color> was interpreted as HTML tag.
@wakaleo wakaleo merged commit 1e51683 into serenity-bdd:main Sep 8, 2024
2 checks passed
@eitzenbe eitzenbe deleted the bugfixs/3523_newpr branch September 9, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants