Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve esm file path issue and '<<cwd>>' (example tests) on windows #678

Merged
merged 7 commits into from
Aug 27, 2024

Conversation

anikghosh256
Copy link
Contributor

@anikghosh256 anikghosh256 commented Jul 26, 2024

Copy link

pkg-pr-new bot commented Aug 27, 2024

commit: a5198db

pnpm add https://pkg.pr.new/sequelize/umzug@678

Open in Stackblitz

@mmkal mmkal force-pushed the windows-esm-path branch from 08ce5a0 to a696dc1 Compare August 27, 2024 13:06
@mmkal
Copy link
Contributor

mmkal commented Aug 27, 2024

@anikghosh256 thanks. I'm going to try getting CI running on Windows on this PR to test, will be force-pushing some commits, hope that's alright.

@mmkal mmkal force-pushed the windows-esm-path branch 4 times, most recently from 8b5a31c to 0ee4338 Compare August 27, 2024 13:43
@mmkal mmkal force-pushed the windows-esm-path branch from 0ee4338 to b95aa80 Compare August 27, 2024 13:51
@mmkal mmkal force-pushed the windows-esm-path branch from b5eae79 to 7b23a11 Compare August 27, 2024 14:15
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.45%. Comparing base (7dc3877) to head (a5198db).
Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #678   +/-   ##
=======================================
  Coverage   99.45%   99.45%           
=======================================
  Files          12       12           
  Lines        1466     1468    +2     
  Branches      269      269           
=======================================
+ Hits         1458     1460    +2     
  Misses          8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmkal mmkal merged commit 3baccd6 into sequelize:main Aug 27, 2024
12 checks passed
@mmkal
Copy link
Contributor

mmkal commented Aug 27, 2024

@anikghosh256 merged. Could you try the pkg.pr.new install command above, and if it works ok for you I can publish a minor bump.

@anikghosh256
Copy link
Contributor Author

@mmkal I've tested the pkg.pr.new install command, and it's working perfectly on my end. You can go ahead with the minor version bump!

Note: I used the example from umzug.mjs .

@anikghosh256
Copy link
Contributor Author

@mmkal waiting for version bump!!

Copy link

Released in v3.8.2.

@mmkal
Copy link
Contributor

mmkal commented Sep 23, 2024

@anikghosh256 released as a patch bump since I think arguably this was just a windows bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants