-
-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve esm file path issue and '<<cwd>>' (example tests) on windows #678
Conversation
commit:
|
08ce5a0
to
a696dc1
Compare
@anikghosh256 thanks. I'm going to try getting CI running on Windows on this PR to test, will be force-pushing some commits, hope that's alright. |
8b5a31c
to
0ee4338
Compare
0ee4338
to
b95aa80
Compare
b5eae79
to
7b23a11
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #678 +/- ##
=======================================
Coverage 99.45% 99.45%
=======================================
Files 12 12
Lines 1466 1468 +2
Branches 269 269
=======================================
+ Hits 1458 1460 +2
Misses 8 8 ☔ View full report in Codecov by Sentry. |
@anikghosh256 merged. Could you try the pkg.pr.new install command above, and if it works ok for you I can publish a minor bump. |
@mmkal waiting for version bump!! |
Released in v3.8.2. |
@anikghosh256 released as a patch bump since I think arguably this was just a windows bug. |
#676