-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MISC] Remove std::ranges::copy and std::cpp20::back_inserter. #54
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/seqan/sharg-parser/8FBjdiB5mv1nuEXkPFe3oiLrjBfK |
9abdd9d
to
a6b6921
Compare
a6b6921
to
4f7bca8
Compare
4f7bca8
to
f59149a
Compare
Codecov Report
@@ Coverage Diff @@
## master #54 +/- ##
==========================================
+ Coverage 95.22% 95.23% +0.01%
==========================================
Files 13 13
Lines 921 923 +2
==========================================
+ Hits 877 879 +2
Misses 44 44
Continue to review full report at Codecov.
|
f59149a
to
af4756f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGFM, thank you!
Follow up of #44
Most changes are euqivalent because we don't need e.g.
std::ranges::find
if we have a common range anyway. IMHO this change even became more readable.The only not nice change is this one
because it is in the snippets and thus code that is exposed to the user.
We might want to think about adding the std/ranges module to the sharg parser or drop gcc-9 support which would make
#include <ranges>
available directly. Then we can change this back.