Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] Remove dependency on ranges::move and cpp20::back_inserter. #47

Merged
merged 3 commits into from
Jan 18, 2022

Conversation

smehringer
Copy link
Member

Follow up of #44

@vercel
Copy link

vercel bot commented Jan 12, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/seqan/sharg-parser/6tSmCr7uVuAQCbJQvbmqDYMHvT3t
✅ Preview: https://sharg-parser-git-fork-smehringer-rangemove-seqan.vercel.app

@smehringer smehringer requested review from a team and eaasna and removed request for a team January 12, 2022 11:22
@codecov
Copy link

codecov bot commented Jan 12, 2022

Codecov Report

Merging #47 (b1b3786) into master (46f9f49) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
- Coverage   95.55%   95.54%   -0.01%     
==========================================
  Files          13       13              
  Lines         944      942       -2     
==========================================
- Hits          902      900       -2     
  Misses         42       42              
Impacted Files Coverage Δ
include/sharg/validators.hpp 100.00% <100.00%> (ø)
include/sharg/detail/type_name_as_string.hpp 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46f9f49...b1b3786. Read the comment docs.

@smehringer smehringer requested a review from eseiler January 12, 2022 12:07
Copy link
Member

@eseiler eseiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one "performance consideration"

include/sharg/validators.hpp Outdated Show resolved Hide resolved
@smehringer
Copy link
Member Author

Huh, Your link was with gcc9,
https://quick-bench.com/q/jQCFzTYw6TuC7utVoDzZGRQmf50
out of interest I've selected gcc10. Simple push_back is very fast here:
https://quick-bench.com/q/LB-Gy0UZioJRltB3jbN--MiYEXQ
too bad I can't select gcc11.

Since performance is not critical I prefer the one line anyway. But it's good to keep in mind I think.

@smehringer smehringer requested a review from eseiler January 17, 2022 13:18
@eseiler eseiler merged commit 4645fbd into seqan:master Jan 18, 2022
@smehringer smehringer deleted the range_move branch January 19, 2022 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants