-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MISC] Remove dependency on ranges::move and cpp20::back_inserter. #47
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/seqan/sharg-parser/6tSmCr7uVuAQCbJQvbmqDYMHvT3t |
Codecov Report
@@ Coverage Diff @@
## master #47 +/- ##
==========================================
- Coverage 95.55% 95.54% -0.01%
==========================================
Files 13 13
Lines 944 942 -2
==========================================
- Hits 902 900 -2
Misses 42 42
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one "performance consideration"
Co-authored-by: Enrico Seiler <[email protected]>
Huh, Your link was with gcc9, Since performance is not critical I prefer the one line anyway. But it's good to keep in mind I think. |
Follow up of #44