-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MISC] Remove dependency of seqan3::detail::type_name_as_string. #40
[MISC] Remove dependency of seqan3::detail::type_name_as_string. #40
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/seqan/sharg-parser/8ndSsGBBaZrNiUsL2wuRWj9AetxQ |
Codecov Report
@@ Coverage Diff @@
## master #40 +/- ##
==========================================
+ Coverage 94.90% 95.54% +0.63%
==========================================
Files 12 13 +1
Lines 903 920 +17
==========================================
+ Hits 857 879 +22
+ Misses 46 41 -5
Continue to review full report at Codecov.
|
Is there a way to avoid the new includes or should I open new Issues / follow up PRs for these? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check if these suggestions work?
Note that you need to adapt the if block with all the types
That works, thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💅
I think you can do a rebase on current master, and then this is good to go :) |
Signed-off-by: Lydia Buntrock <[email protected]>
Signed-off-by: Lydia Buntrock <[email protected]>
c315cd7
to
a2bbb08
Compare
Resolves #15
New seqan3 includes in the new test file:#include <seqan3/utility/type_list/traits.hpp>#include <seqan3/utility/type_list/type_list.hpp>