Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] Remove dependency of the seqan3 test_accessor. #14

Closed
6 tasks done
smehringer opened this issue Dec 1, 2021 · 0 comments · Fixed by #39
Closed
6 tasks done

[MISC] Remove dependency of the seqan3 test_accessor. #14

smehringer opened this issue Dec 1, 2021 · 0 comments · Fixed by #39
Assignees

Comments

@smehringer
Copy link
Member

smehringer commented Dec 1, 2021

We use the test_accessor to test protected member(function)s and will continue to need this.
Therefore we need to copy it over from seqan3.

Blocked by #7

Tasks:

  • copy seqan3/include/core/detail/test_accessor.hpp to sharg/detail/test_accessor.hpp and change the namespace to sharg
  • Change all forward declarations to include sharg/detail/test_accessor.hpp instead*
  • Switch from befriending the seqan3::detail::test_accessor to sharg::detail::test_accessor in places in inlcude/sharg
  • Change the namespace of test_accessor instances in test/unit from seqan3 to sharg
  • Check if tests pass
  • Where-ever you changed includes in the include/ directory, check whether the file does not inlcude any seqan3 files anymore and tick off the corresponding ones in [FEATURE] Make the argument parser independent of seqan3. #6

*

namespace seqan3::detail
{

struct test_accessor;

} // seqan3::detail
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants