Merge pull request #223 from eseiler/fix/header

[INFRA] Do not use TDL in header tests
seqan · Feb 2, 2024 · 5c99a11 · 5c99a11
2 parents 518c1bb + 2276ab0
commit 5c99a11
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 2 deletions.
diff --git a/.github/workflows/ci_misc.yml b/.github/workflows/ci_misc.yml
@@ -49,13 +49,27 @@ jobs:
             build_type: Release
             test_threads: 1 # snippets create and delete files and some separate tests create/delete the same files
 
+          - name: "Header clang17 cpp23"
+            compiler: "clang-17"
+            build: header
+            build_type: Release
+            cxx_flags: "-stdlib=libc++ -std=c++23"
+            test_threads: 2
+
           - name: "Header clang17"
             compiler: "clang-17"
             build: header
             build_type: Release
             cxx_flags: "-stdlib=libc++"
             test_threads: 2
 
+          - name: "Header gcc13 cpp23"
+            compiler: "gcc-13"
+            build: header
+            build_type: Debug
+            cxx_flags: "-std=c++23"
+            test_threads: 2
+
           - name: "Header gcc13"
             compiler: "gcc-13"
             build: header
@@ -93,10 +107,12 @@ jobs:
           cd sharg-build
           cmake ../sharg/test/${{ matrix.build }} -DCMAKE_BUILD_TYPE=${{ matrix.build_type }} \
                                                   -DCMAKE_CXX_FLAGS="${{ matrix.cxx_flags }}" \
-                                                  -DSHARG_VERBOSE_TESTS=OFF
+                                                  -DSHARG_VERBOSE_TESTS=OFF \
+                                                  ${{ contains(matrix.name, 'Header') && '-DSHARG_NO_TDL=ON' || '' }}
+
           case "${{ matrix.build }}" in
             snippet) make -j2 gtest_build yaml-cpp;;
-            header) make -j2 gtest_build gbenchmark_build yaml-cpp;;
+            header) make -j2 gtest_build gbenchmark_build;;
           esac
 
       - name: Build tests

diff --git a/include/sharg/validators.hpp b/include/sharg/validators.hpp
@@ -12,8 +12,10 @@
 
 #pragma once
 
+#include <algorithm>
 #include <any>
 #include <concepts>
+#include <exception>
 #include <fstream>
 #include <ranges>
 #include <regex>