[DOC] clarification how shapes are applied in kmer-hash #2981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## master #2981 +/- ##
=======================================
Coverage 98.19% 98.19%
=======================================
Files 267 267
Lines 11521 11521
=======================================
Hits 11313 11313
Misses 208 208
Continue to review full report at Codecov.
|
SGSSGene
force-pushed
the
fix/wrong_way_shape
branch
from
705a777 to
6accbea
Compare
eseiler
approved these changes
May 16, 2022
smehringer
requested changes
May 16, 2022
Update test/snippet/search/views/kmer_hash.cpp Update include/seqan3/search/views/kmer_hash.hpp Co-authored-by: Svenja Mehringer <[email protected]>
SGSSGene
force-pushed
the
fix/wrong_way_shape
branch
from
cb6725a to
17b2d07
Compare
smehringer
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some clarification on the direction of how shapes are applied when computing hashes.
This intends to solve #2832