Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Add a cookbook entry for an enum validator #2695

Conversation

Irallia
Copy link
Contributor

@Irallia Irallia commented Jun 1, 2021

After creating my own enum validator in iGenVar, has @eseiler suggested to add this as a cookbook entry into the seqan3 documentation.
I have collected all the necessary changes for this pr and put them together in a single file.

@Irallia Irallia self-assigned this Jun 1, 2021
@vercel
Copy link

vercel bot commented Jun 1, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/seqan/seqan3/bv6741itxzir5mBRbZPM26P8X5Ew
✅ Preview: https://seqan3-git-fork-irallia-doc-argumentparsercookbo-b46d25.vercel.app

@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #2695 (2191d71) into master (f5e732d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2695   +/-   ##
=======================================
  Coverage   98.23%   98.23%           
=======================================
  Files         276      276           
  Lines       10885    10885           
=======================================
  Hits        10693    10693           
  Misses        192      192           
Impacted Files Coverage Δ
include/seqan3/argument_parser/validators.hpp 91.39% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5e732d...2191d71. Read the comment docs.

Signed-off-by: Lydia Buntrock <[email protected]>
@Irallia Irallia force-pushed the doc/argument_parser/cookbook_entry_for_enum_validator branch from cc0998b to 7ef47e4 Compare June 2, 2021 10:27
Signed-off-by: Lydia Buntrock <[email protected]>
@marehr marehr requested a review from eseiler June 21, 2021 08:43
@eseiler eseiler removed their request for review October 1, 2021 15:29
@smehringer
Copy link
Member

@Irallia Can this be moved to sharg? Also (I quickly skimmed the code), coudn't the same be achieved with a value_list_validator?

@Irallia
Copy link
Contributor Author

Irallia commented Mar 31, 2022

We would like to move this to the sharg parser: seqan/sharg-parser#87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants